Prevent whitespace from passing honeypot checks#48
Open
anthonymfowler15 wants to merge 1 commit intocurtis:masterfrom
Open
Prevent whitespace from passing honeypot checks#48anthonymfowler15 wants to merge 1 commit intocurtis:masterfrom
anthonymfowler15 wants to merge 1 commit intocurtis:masterfrom
Conversation
sunny
reviewed
Sep 7, 2021
|
|
||
| def protect_from_spam | ||
| head :ok if honeypot_fields.any? { |f,l| !params[f].blank? } | ||
| head :ok if honeypot_fields.any? { |f,l| !params[f].blank? || params[f].to_s.length > 0 } |
Contributor
There was a problem hiding this comment.
Perhaps this could be simplified to the one string value we allow:
Suggested change
| head :ok if honeypot_fields.any? { |f,l| !params[f].blank? || params[f].to_s.length > 0 } | |
| head :ok if honeypot_fields.any? { |f, _| params[f].to_s != "" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a honeypot field is filled with a newline (
"\n"),protect_from_spamdoes not properly block the request. This is because"\n".blank?returns true.Related Issue
#47
Motivation and Context
As described in the description, this change will make
protect_from_spammore robust and block requests where there are any values in the honeypot fields.Screenshots (if appropriate):
N/A
Types of changes
Checklist: